Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54984

Final deprecation / removal of MUC stuff deprecated in 2.6

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide
      1. Confirm that the following methods are not being used anywhere in Moodle.
        • cache_definition
          • should_be_persistent
          • get_persistent_max_size
        • cache
          • is_using_persist_cache
          • is_in_persist_cache
          • get_from_persist_cache
          • set_in_persist_cache
          • delete_from_persist_cache
        • cache_store
          • cleanup
      1. Copy cachetest.php to the Moodle installation root and open it on a browser.
        • Confirm that the exception messages for the deprecated functions are being properly shown.
      Show
      Confirm that the following methods are not being used anywhere in Moodle. cache_definition should_be_persistent get_persistent_max_size cache is_using_persist_cache is_in_persist_cache get_from_persist_cache set_in_persist_cache delete_from_persist_cache cache_store cleanup Copy cachetest.php to the Moodle installation root and open it on a browser. Confirm that the exception messages for the deprecated functions are being properly shown.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54984-master
    • Story Points:
      1
    • Sprint:
      3.2 Sprint 3

      Description

      From Russell Smith, in devs chat:

      As a current example, the MUC is_persist set of functions was deprecated in 2.6, and is still there. At what point is it possible to remove it?

      It seems that we missed those (have not found them in this epic list), and there are a number of them:

       

      $ ag 'deprecated since 2.'
      classes/definition.php
      251: * @deprecated since 2.9
      848: * @deprecated since 2.6
      878: * @deprecated since 2.6

      classes/store.php
      269: * @deprecated since 2.5

      classes/loaders.php
      954: * @deprecated since 2.6
      976: * @deprecated since 2.6
      1003: * @deprecated since 2.6
      1058: * @deprecated since 2.6
      1109: * @deprecated since 2.6

      tests/fixtures/lib.php
      299: * @deprecated since 2.9

      Ciao

        Attachments

          Activity

            People

            Assignee:
            jpataleta Jun Pataleta
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16