Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55020

Report pluging installation from zip archive error

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to the github repository of a plugin, for example https://github.com/moodleou/moodle-report_customsql
      2. Download the source code as a zip file. The key point of downloading from Github is to force Moodle to rename the root folder inside the ZIP during the installation.
      3. Go to Site administration > Plugins > Install plugin
      4. Install the plugin from the zip file
      5. Make sure it is correctly installed

      Additional testing instructions to eliminate possible regressions:

      1. Download the zip from https://moodle.org/plugins/report_customsql
      2. Install plugin from the zip file
      3. Install some plugin from the plugins directory without manually downloading zip
      Show
      Go to the github repository of a plugin, for example https://github.com/moodleou/moodle-report_customsql Download the source code as a zip file. The key point of downloading from Github is to force Moodle to rename the root folder inside the ZIP during the installation. Go to Site administration > Plugins > Install plugin Install the plugin from the zip file Make sure it is correctly installed Additional testing instructions to eliminate possible regressions: Download the zip from https://moodle.org/plugins/report_customsql Install plugin from the zip file Install some plugin from the plugins directory without manually downloading zip
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55020-master-pluginzip

      Description

      When installing a new report plugin, with the component name report_benchmark, I get an error with any Moodle 3.x version (but not with Moodle 2.x versions).

      " _ Plugin report_benchmark does not declare valid $plugin->component in its version.php.

      line 328 of \lib\classes\plugin_manager.php: call to debugging()
      line 348 of \lib\classes\plugin_manager.php: call to core_plugin_manager->load_present_plugins()
      line 217 of \lib\classes\plugininfo\base.php: call to core_plugin_manager->get_present_plugins()
      line 143 of \lib\classes\plugininfo\base.php: call to core\plugininfo\base->load_disk_version()
      line 97 of \lib\classes\plugininfo\base.php: call to core\plugininfo\base::make_plugin_instance()
      line 408 of \lib\classes\plugin_manager.php: call to core\plugininfo\base::get_plugins()
      line 368 of \lib\classes\plugin_manager.php: call to core_plugin_manager->get_plugins_of_type()
      line 1131 of \lib\classes\plugin_manager.php: call to core_plugin_manager->get_plugins()
      line 1132 of \admin\renderer.php: call to core_plugin_manager->missing_dependencies()
      line 212 of \admin\renderer.php: call to core_admin_renderer->missing_dependencies()
      line 662 of \admin\index.php: call to core_admin_renderer->upgrade_plugin_check_page()_"

      Furthemore then "Backups" report plugin disappeared!

      Looking at the ./report/ directory it appears that during the installation process

      • the "./report/backups" is renamed "benchmark";
      • the "moodlebenchmark-master" is not renamed;

      After manually renaming of theses directories everything goes fine.

        Attachments

        1. customsql1.jpg
          customsql1.jpg
          42 kB
        2. customsql2.jpg
          customsql2.jpg
          59 kB
        3. customsql3.jpg
          customsql3.jpg
          112 kB
        4. customsql4.jpg
          customsql4.jpg
          52 kB
        5. customsql5.jpg
          customsql5.jpg
          24 kB
        6. install_report_error_moodle31_01.png
          install_report_error_moodle31_01.png
          55 kB
        7. install_report_error_moodle31_02.png
          install_report_error_moodle31_02.png
          29 kB
        8. install_report_error_moodle31_03.png
          install_report_error_moodle31_03.png
          61 kB
        9. install_report_error_moodle31_04.png
          install_report_error_moodle31_04.png
          68 kB
        10. install_report_error_moodle31_05.png
          install_report_error_moodle31_05.png
          72 kB
        11. install_report_error_moodle31_06.png
          install_report_error_moodle31_06.png
          38 kB
        12. install_report_error_moodle31_07.png
          install_report_error_moodle31_07.png
          17 kB
        13. install_report_error_moodle31_08.png
          install_report_error_moodle31_08.png
          58 kB
        14. overviewstats1.jpg
          overviewstats1.jpg
          116 kB
        15. overviewstats2.jpg
          overviewstats2.jpg
          51 kB

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              jfruitet Jean FRUITET
              Integrator:
              Andrew Nicols
              Tester:
              Marina Glancy
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 30 minutes
                  3h 30m