Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55050

grunt watch causes eslint of all files on any js change.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      It's kind of difficult to test this, the most reliable way is probably to:

      1. To run grunt watch --verbose
      2. Edit a amd src file or yui src file
      3. Inspect the output of eslint task and ensure it only runs eslint on the file which was edited (compare with before patch to see the difference)

      Alternatively you could observe that the eslint part runs much quicker.

      Show
      It's kind of difficult to test this, the most reliable way is probably to: To run grunt watch --verbose Edit a amd src file or yui src file Inspect the output of eslint task and ensure it only runs eslint on the file which was edited (compare with before patch to see the difference) Alternatively you could observe that the eslint part runs much quicker.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-55050-master

      Description

      Every time we do a JS change, we eslint all the js files rather than just the modified ones. Doh

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Andrew Nicols
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16