Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55062

Upload users admin tool incorrectly updates authentication method for existing users when not included in CSV

XMLWordPrintable

    • MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • MDL-55062_master
    • Hide
      1. Create test users using the following CSV file content via 'Site administration' > 'Users' > 'Upload users' - 

        username,firstname,lastname,email,auth
        		 
        test.account1,Test,Account1,test1@example.com,nologin
        		 
        test.account2,Test,Account2,test2@example.com,nologin

      2. Update the same users using the following CSV file content via 'Site administration' > 'Users' > 'Upload users' - 

        username,firstname,lastname,email
        		 
        test.account1,Test,Account1,test1@example.com
        		 
        test.account2,Test,Account2,test2@example.com

      3. Change the following options:
        1. Upload type: Add new and update existing users
        2. Existing user details: Override with file
      4. Confirm that authentication method remains nologin
      5. Perform additional smoke testing, including:
        1. Override with file and defaults
        2. No changes
      Show
      Create test users using the following CSV file content via 'Site administration' > 'Users' > 'Upload users' - username,firstname,lastname,email,auth test.account1,Test,Account1,test1@example.com,nologin test.account2,Test,Account2,test2@example.com,nologin Update the same users using the following CSV file content via 'Site administration' > 'Users' > 'Upload users' - username,firstname,lastname,email test.account1,Test,Account1,test1@example.com test.account2,Test,Account2,test2@example.com Change the following options: Upload type: Add new and update existing users Existing user details: Override with file Confirm that authentication method remains nologin Perform additional smoke testing, including: Override with file and defaults No changes

      The admin tool upload users https://docs.moodle.org/30/en/Upload_users, updates the authentication method for existing users, even when the selected options should not allow it to.

      How to reproduce:

      Create test users using following CSV file:

      username,firstname,lastname,email,auth
      		 
      test.account1,Test,Account1,test1@example.com,nologin
      		 
      test.account2,Test,Account2,test2@example.com,nologin

      Update the same users using following file (same file removed auth column)

      username,firstname,lastname,email
      		 
      test.account1,Test,Account1,test1@example.com
      		 
      test.account2,Test,Account2,test2@example.com

      Change the following options:
      Upload type: Add new and update existing users
      Existing user details: Override with file

      Result:
      Authentication method changed nologin-->manual

      Expected result:
      Authentication method remains nologin.

      Since the auth column is omitted from the uploaded CSV file and the selected option for Existing user details is "Override with file". I expect that it will not change.

            markn Mark Nelson
            erazorbg Dimitar Ivanov
            Jake Dallimore Jake Dallimore
            Andrew Lyons Andrew Lyons
            John Okely John Okely
            Votes:
            2 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.