Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55082

Core search areas don't sort recordset by timemodified

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1.2
    • Component/s: Global search
    • Labels:
    • Testing Instructions:
      Hide

      Install and configure Solr.

      Run all unit tests, including with Solr enabled (see search/engine/solr/tests/engine_test.php on how to enable Solr for phpunit).

      1. With global search enabled, create a course with various activities and resources. Also some forum posts. You may want to include something easily searchable in the title, like "FindMe".
      2. Index the site.
      3. Perform a search and ensure you can find everything you expect to.
      4. Create a few more activities and forum posts.
      5. Allow cron to run to perform an incremental index.
      6. Search for the new content, and ensure you can find it.
      Show
      Install and configure Solr. Run all unit tests, including with Solr enabled (see search/engine/solr/tests/engine_test.php on how to enable Solr for phpunit). With global search enabled, create a course with various activities and resources. Also some forum posts. You may want to include something easily searchable in the title, like "FindMe". Index the site. Perform a search and ensure you can find everything you expect to. Create a few more activities and forum posts. Allow cron to run to perform an incremental index. Search for the new content, and ensure you can find it.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull 3.1 Branch:
    • Pull Master Branch:
      MDL-55082-master

      Description

      The phpdoc for \core_search\area\base::get_recordset_by_timestamp() clearly states that records should be returned in time-modified order, but many of the core search areas, including base_activity, do not do this. In fact they return them in no order (DB returned order).

      While an implementation detail in manager prevented this from being as important up front, it's going to be a serious hindrance to fixing many of the things in MDL-55054, and makes creating our initial index of our production site much harder.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Sep/16