[MDL-55082] Core search areas don't sort recordset by timemodified - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1
Fix Version/s: 3.1.2
Component/s: Global search
Labels:
- ci

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/merrill-oakland/moodle.git
Pull Master Branch:
~~MDL-55082~~-master
Pull Master Diff URL:
https://github.com/merrill-oakland/moodle/compare/b8474fe...MDL-55082-master
Testing Instructions:
Hide

Install and configure Solr.

Run all unit tests, including with Solr enabled (see search/engine/solr/tests/engine_test.php on how to enable Solr for phpunit).

With global search enabled, create a course with various activities and resources. Also some forum posts. You may want to include something easily searchable in the title, like "FindMe".

Index the site.

Perform a search and ensure you can find everything you expect to.

Create a few more activities and forum posts.

Allow cron to run to perform an incremental index.

Search for the new content, and ensure you can find it.
Show
Install and configure Solr. Run all unit tests, including with Solr enabled (see search/engine/solr/tests/engine_test.php on how to enable Solr for phpunit). With global search enabled, create a course with various activities and resources. Also some forum posts. You may want to include something easily searchable in the title, like "FindMe". Index the site. Perform a search and ensure you can find everything you expect to. Create a few more activities and forum posts. Allow cron to run to perform an incremental index. Search for the new content, and ensure you can find it.

Description

The phpdoc for \core_search\area\base::get_recordset_by_timestamp() clearly states that records should be returned in time-modified order, but many of the core search areas, including base_activity, do not do this. In fact they return them in no order (DB returned order).

While an implementation detail in manager prevented this from being as important up front, it's going to be a serious hindrance to fixing many of the things in ~~MDL-55054~~, and makes creating our initial index of our production site much harder.

Attachments

Issue Links

has been marked as being related by

MDL-55357 user_search_testcase::test_users_document random fail

Closed

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: Rajesh Taneja

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Eric Merrill, Frédéric Massart, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 01/Jul/16 6:52 AM

Updated:: 27/Jul/16 11:33 PM

Resolved:: 15/Jul/16 3:38 AM

Fix Release Date:: 12/Sep/16