Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55087

Upgrade HTMLPurifier for Moodle 3.2 release

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Stolen from MDL-52651

      1. Create a forum.
      2. In a discussion, add in HTML links with and without the target attribute.
        • Note: You will need to only use the value _blank for target as other values are filtered out.
      3. Save.
      4. View the discussion and verify that any links that have the target attribute will have rel=noreferrer attribute added. Make sure the when opening a target="_blank" link that the original page is not redirected.
      5. Try the same sort of thing in other text areas and see if any don't add the attribute.

      Example:

      This:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>
       
      Becomes:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer" id="yui_3_15_0_3_1425447153706_281">Test my link</a>

      • Run all unit tests and check that failures don't relate to this issue.
      Show
      Stolen from MDL-52651 Create a forum. In a discussion, add in HTML links with and without the target attribute. Note: You will need to only use the value _blank for target as other values are filtered out. Save. View the discussion and verify that any links that have the target attribute will have rel=noreferrer attribute added. Make sure the when opening a target="_blank" link that the original page is not redirected. Try the same sort of thing in other text areas and see if any don't add the attribute. Example: This: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>   Becomes: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer" id="yui_3_15_0_3_1425447153706_281">Test my link</a> Run all unit tests and check that failures don't relate to this issue.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-55087-master
    • Sprint:
      3.2 Sprint 7

      Description

      Update HTMLPurifier [insert version here]

      Note that they have accepted commit by cameron1729
      We will need to change our wrapper

        Attachments

          Activity

            People

            Assignee:
            abgreeve Adrian Greeve
            Reporter:
            marina Marina Glancy
            Peer reviewer:
            cameron1729
            Integrator:
            Dan Poltawski
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16