Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55126

Deprecated get_records_csv() and put_records_csv()

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run the following from the command line on a moodle master instance:

      git grep -n 'get_records_csv'
      

      git grep -n 'put_records_csv'
      

      The only results should be locations in lib/deprecatedlib.php and upgrade.txt

      Show
      Run the following from the command line on a moodle master instance: git grep -n 'get_records_csv' git grep -n 'put_records_csv' The only results should be locations in lib/deprecatedlib.php and upgrade.txt
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-55126-master
    • Story Points:
      1
    • Sprint:
      3.2 Sprint 3

      Description

      While searching for php 7.1 incompatible code I found methods get_record_csv() and put_records_csv() that are never used, have some debug echo and also use \r\n as the line separator....

      We need to deprecate them

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Jun Pataleta
              Integrator:
              David Monllaó
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16