Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55155

Setting 'smtphosts' is defined in plugin message_email but is used in core

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.4, 3.1
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE

      Description

      At some point, the smtphosts setting has been moved from the core config into the message_email plugin settings, but the get_mailer() function is still using it regardless of whether the plugin is installed. This doesn't seem like a good idea, as it means a Moodle service could be sending stuff to an SMTP server that the administrator is unable to see or change (apart from forcing it in config.php). To reproduce on a clean Moodle install:

      1. Set up an SMTP server in the smtphosts setting
      2. Uninstall the message_email plugin
      3. Confirm that mail is still being sent to the SMTP server
      4. Confirm that the smtphosts setting is unavailable for editing

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              maherne Michael Aherne
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16