Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55165

Fix lint errors in less which actually change css. (part 2)

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Disable all text editor plugins but plain html area
      2. Go to admin > settings frontpage
      3. VERIFY: the front page summary field looks the same before and after the the patch
      1. Bring up an atto editor
      2. Click the link button
      3. The dialogue will pop up
      4. VERIFY: the close button looks the same before and after the patch
      1. Go to a course and add the search forums block
      2. VERIFY: Ensure the search forums block looks the same before and after the patch
      1. Add the login block to the front page
      2. VERIFY: ensure the login button looks the same before and after the patch
      1. Add a numerical question
      2. VERIFY: the answer form looks the same before and after the patch
      1. Go to the course form
      2. VERIFY: that the date fields look the same before and after the patch
      1. On a course, move an activity around
      2. VERIFY: the spinner looks the same before and after the patch
      1. Go to the course management interface
      2. On the category there is an edit button with a dropdown
      3. VERIFY: the dropdown looks the same before and after the patch
      1. Go to the course particpation report
      2. VERIFY: Ensure the form looks the same before and after the patch
      1. Go to my private files
      2. Go to a repository
      3. Look at the view items on top riigth
      4. VERIFY: ensure they look the same before and after the patch
      Show
      Disable all text editor plugins but plain html area Go to admin > settings frontpage VERIFY: the front page summary field looks the same before and after the the patch Bring up an atto editor Click the link button The dialogue will pop up VERIFY: the close button looks the same before and after the patch Go to a course and add the search forums block VERIFY: Ensure the search forums block looks the same before and after the patch Add the login block to the front page VERIFY: ensure the login button looks the same before and after the patch Add a numerical question VERIFY: the answer form looks the same before and after the patch Go to the course form VERIFY: that the date fields look the same before and after the patch On a course, move an activity around VERIFY: the spinner looks the same before and after the patch Go to the course management interface On the category there is an edit button with a dropdown VERIFY: the dropdown looks the same before and after the patch Go to the course particpation report VERIFY: Ensure the form looks the same before and after the patch Go to my private files Go to a repository Look at the view items on top riigth VERIFY: ensure they look the same before and after the patch
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-55165-master

      Description

      Over in MDL-55167 the changes made to less files have been purely cosmetic, not making a difference to the generated css. In this issue we will fix the errors and test them.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16