Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55167

Add stylelint config and make less compliant with CS (part 1)

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Repeat on windows/linux at least:

      1. Run npm install - ensure your dependencies are up to date
      2. Run `grunt css` and ensure less files are linted
      3. Verify no lint errors are reported
      4. Run `grunt` and ensure the executation completes
      5. Verify no built files have been changed
      Show
      Repeat on windows/linux at least: Run npm install - ensure your dependencies are up to date Run `grunt css` and ensure less files are linted Verify no lint errors are reported Run `grunt` and ensure the executation completes Verify no built files have been changed
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-55167-master

      Description

      Stage one of adding stylelint, is getting the basics in place and keeping our less files linted

      1. Add stylelint config matching css coding style
      2. Add stylelint checking to grunt
      3. Ensure less files pass lint before building
      4. Fix all the stylistic lint errors in less (which don't impact on actual built css, the ones which affect the css will be fixed in MDL-55165)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16