Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55172

Verify and decide if some amd modules should be moved to subsystem (from core)

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_32_STABLE

      Description

      With MDL-55133 we have got amd modules working properly (frankenstyle component names). And there is already one subsystem amd module (MDL-55000).

      Looking for current modules, I detected that there were a bunch of them that, maybe, could be moved to their own subsystem, instead of using the core hodgepodge.

      So, this issue is about 1) decide if we should be putting the amd modules under their own subsystem, when it's available and 2) do it if decided.

      Here it's the list of modules (basic grep) not belonging to plugins:

      $ ag "js_call_amd.*\('core"
      admin/roles/permissions.php
      206:$PAGE->requires->js_call_amd('core/permissionmanager', 'initialize', array($arguments));
       
      lib/form/autocomplete.php
      124:        $PAGE->requires->js_call_amd('core/form-autocomplete', 'enhance', $params = array('#' . $id, $this->tags, $this->ajax,
       
      lib/outputrequirementslib.php
      1591:        $this->js_call_amd('core/log', 'setConfig', array($logconfig));
       
      lib/outputrenderers.php
      1067:            $this->page->requires->js_call_amd('core/notification', 'init', array(
      3245:        $this->page->requires->js_call_amd('core/search-input', 'init', array($id));
       
      tag/classes/manage_table.php
      103:        $PAGE->requires->js_call_amd('core/tag', 'initManagePage', array());
       
      tag/classes/renderer.php
      79:        $this->page->requires->js_call_amd('core/tag', 'initTagindexPage');
       
      tag/manage.php
      200:    $PAGE->requires->js_call_amd('core/tag', 'initManageCollectionsPage', array());
      

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated: