Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55207

Improve error message when validating ipaddresses in admin_setting_configiplist

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) Go to any configiplist eg the ipblock and enter a couple correct and incorrect ip addresses and some whitespace lines and save, eg

      259.0.0.0
      fish
       
      1.2.3.4
      cow
      

      2) Confirm that it correctly ignores blank lines, or lines which only contains whitespace
      3) Confirm that it echo's back the exact lines which are invalid:

      Show
      1) Go to any configiplist eg the ipblock and enter a couple correct and incorrect ip addresses and some whitespace lines and save, eg 259.0.0.0 fish   1.2.3.4 cow 2) Confirm that it correctly ignores blank lines, or lines which only contains whitespace 3) Confirm that it echo's back the exact lines which are invalid:
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-55207-configiplist-errors

      Description

      When managing a large number of ipaddresses in an instance of admin_setting_configiplist it can be hard to know which line fails if you mess something up. This patch makes the error message tell you exactly which line is the issue instead of a generic failure message.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16