Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55240

Revert changes in MDL-54772 - Assignment: Annotates are off screen + error message when clicking annotation

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.0.5, 3.1.1
    • 3.0.6, 3.1.2
    • Assignment
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-55240-master
    • Hide
      1. Create a course with an assignment that accepts File submisisons.
      2. Login as a student and submit a PDF file.
      3. Login as a teacher and grade the submission.
      4. Add a comment.
      5. Add a stamp annotation.
      6. Click again on the comment.
        • Confirm that you can edit it.
      7. Use the select tool and select the stamp annotation.
      8. Confirm that you can drag it.
      9. Add other annotations, such as shapes, pen, line, highlight.
        • Confirm that you can move them around when selected with the select tool.
      10. Add another stamp annotation and make sure that it goes outside the page's printable area. The easiest way would be to click outside the page's bounds.
      11. Save the grading page and view the list of submissions.
      12. Click View annotated PDF
      13. Login as a student and view the annotated PDF.
      14. Click and drag on the annotations.
        • Confirm that you cannot drag the annotations.
        • Confirm that there is no error dialogue displayed.
      Show
      Create a course with an assignment that accepts File submisisons. Login as a student and submit a PDF file. Login as a teacher and grade the submission. Add a comment. Add a stamp annotation. Click again on the comment. Confirm that you can edit it. Use the select tool and select the stamp annotation. Confirm that you can drag it. Add other annotations, such as shapes, pen, line, highlight. Confirm that you can move them around when selected with the select tool. Add another stamp annotation and make sure that it goes outside the page's printable area. The easiest way would be to click outside the page's bounds. Save the grading page and view the list of submissions. Click View annotated PDF Login as a student and view the annotated PDF. Click and drag on the annotations. Confirm that you cannot drag the annotations. Confirm that there is no error dialogue displayed.

    Description

      The patch for MDL-54772 created the following regressions:

      1. Existing comments can no longer be re-edited
      2. No longer able to add saved quicklist comments
      3. Using the 'drag' tool to move a comment, the whole page moves/scrolls along with it if it can.

      Reverting the changes fixes the issue.

      We'll have to find a different approach to resolve the issues raised in MDL-54772. Perhaps resolving MDL-54815 where we will not allow any of the annotations to go outside the page's bounds would be the way to go here and prevent the annotations from being floated outside the PDF viewer window in the first place.

      Attachments

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54772 Assignment: Annotates are off screen + error message when clicking annotation

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              jpataleta Jun Pataleta
              jpataleta Jun Pataleta
              Jake Dallimore Jake Dallimore
              Dan Poltawski Dan Poltawski
              Rajesh Taneja Rajesh Taneja
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Sep/16