Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55245

Attempting to select text in PDF annotation comments drags the comment box

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Create an assignment with assignsubmission_file and assignfeedback_editpdf enabled.
      • As a student, submit a file (of a format that can be converted to PDF).
      • As a teacher, add a comment to the generated PDF.
      • Attempt to drag-select some text within the comment and make edits to it.
      • Verify that the text can be selected and edited.
      • Select the 'select' tool and attempt to drag the comment box.
      • Verify that the comment can now be dragged around the page.
      • Select the 'comment' tool again.
      • Verify that text within the comment can once again be selected and edited.
      Show
      Create an assignment with assignsubmission_file and assignfeedback_editpdf enabled. As a student, submit a file (of a format that can be converted to PDF). As a teacher, add a comment to the generated PDF. Attempt to drag-select some text within the comment and make edits to it. Verify that the text can be selected and edited. Select the 'select' tool and attempt to drag the comment box. Verify that the comment can now be dragged around the page. Select the 'comment' tool again. Verify that text within the comment can once again be selected and edited.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55245-master

      Description

      If you try to drag-select text within PDF annotation comments, the comment box itself gets dragged around the page, even while still in comment editing mode.

      This patch enables comment text to be selected, and the comment box will only be dragged if the 'select' tool has been selected as the current editing tool.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Sep/16