[MDL-55245] Attempting to select text in PDF annotation comments drags the comment box - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1, 3.1.1, 3.2
Fix Version/s: 3.1.2
Component/s: Assignment
Labels:
- ci
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
https://github.com/lucisgit/moodle
Pull Master Branch:
~~MDL-55245~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...lucisgit:MDL-55245-master
Testing Instructions:
Hide

Create an assignment with assignsubmission_file and assignfeedback_editpdf enabled.

As a student, submit a file (of a format that can be converted to PDF).

As a teacher, add a comment to the generated PDF.

Attempt to drag-select some text within the comment and make edits to it.

Verify that the text can be selected and edited.

Select the 'select' tool and attempt to drag the comment box.

Verify that the comment can now be dragged around the page.

Select the 'comment' tool again.

Verify that text within the comment can once again be selected and edited.
Show
Create an assignment with assignsubmission_file and assignfeedback_editpdf enabled. As a student, submit a file (of a format that can be converted to PDF). As a teacher, add a comment to the generated PDF. Attempt to drag-select some text within the comment and make edits to it. Verify that the text can be selected and edited. Select the 'select' tool and attempt to drag the comment box. Verify that the comment can now be dragged around the page. Select the 'comment' tool again. Verify that text within the comment can once again be selected and edited.

Description

If you try to drag-select text within PDF annotation comments, the comment box itself gets dragged around the page, even while still in comment editing mode.

This patch enables comment text to be selected, and the comment box will only be dragged if the 'select' tool has been selected as the current editing tool.

Attachments

Issue Links

Discovered while testing

MDL-55322 Mod Assign: Dragging comments in grading interface scrolls the page on mobile site

Closed

will help resolve

MDL-54818 Improve assignment PDF annotation

Closed

Activity

People

Assignee:: Tony Butler

Reporter:: Tony Butler

Peer reviewer:: Jake Dallimore

Integrator:: Eloy Lafuente (stronk7)

Tester:: Damyon Wiese

Participants:: CiBoT, Damyon Wiese, David Monllaó, Eloy Lafuente (stronk7), Jake Dallimore, Tony Butler

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 16/Jul/16 6:44 AM

Updated:: 28/Jul/16 11:54 PM

Resolved:: 28/Jul/16 10:18 PM

Fix Release Date:: 12/Sep/16