Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55249

Feedback Activity reports incorrect status

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.15, 2.8.12, 2.9.7, 3.0.5, 3.1.1
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course (Course A) with a feedback activity that is not anonymous and has 2 pages of questions.
      2. Create a second course (Course B) with a feedback activity that is not anonymous.
      3. Enroll the same user into each course.
      4. Log in as the user and go to Course A and start the feedback activity by answering the questions on the first page and going to the second (this should create a record in the completedtmp table).
      5. Now go into Course A (as administrator) and check the status of the non-respondents in that feedback activity.
      6. Verify that that it says "Started"
      7. Now go into Course B (as administrator) and check the status of the non-respondents in that feedback activity.
      8. Verify that that it says "Not started"
      Show
      Create a course (Course A) with a feedback activity that is not anonymous and has 2 pages of questions. Create a second course (Course B) with a feedback activity that is not anonymous. Enroll the same user into each course. Log in as the user and go to Course A and start the feedback activity by answering the questions on the first page and going to the second (this should create a record in the completedtmp table). Now go into Course A (as administrator) and check the status of the non-respondents in that feedback activity. Verify that that it says "Started" Now go into Course B (as administrator) and check the status of the non-respondents in that feedback activity. Verify that that it says "Not started"
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-55249_m32v1

      Description

      In a newly created feedback activity, in a course that has not been accessed by the students yet, we were seeing status of "started" for some of the students when viewing non-respondents. Upon further investigation, we discovered that if you created a new feedback activity in any course and enrolled one of the "started" users, that user immediately showed as "started" as the status under view non-respondents.

      I believe this is happening because when a user starts a feedback activity it creates a record in mdl_feedback_completedtmp and the query that checks that table for records is only looking for the userid and not the feedbackid as well.

      Steps to replicate:

      Create a course (Course A) with a feedback activity that is not anonymous and has 2 pages of questions.
      Create a second course (Course B) with a feedback activity that is not anonymous.
      Enroll the same user into each course.
      Log in as the user and go to Course A and start the feedback activity by answering the questions on the first page and going to the second (this should create a record in the completedtmp table).
      Now go into Course B (as administrator) and check the status of the non-respondents in that feedback activity. You will see that it says "started" even though the user started the one in Course A and not Course B.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16