Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55252

Chat activity missing Moodle internal test in lib and locallib

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.1.1
    • 3.0.6, 3.1.2
    • Chat
    • MOODLE_31_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • Easy
    • Hide

      Manual Testing:

      1. Open the files and verify that they have been added
      2. Try to browse to the files using your favorite web browser and verify that nothing is displayed.
      Show
      Manual Testing: Open the files and verify that they have been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.

    Description

      Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
      defined('MOODLE_INTERNAL') || die();

      That check is missing from both lib.php and locallib.php in the chat module. (It is probably missing from other modules too)

      Attachments

        Activity

          People

            sbourget Stephen Bourget
            sbourget Stephen Bourget
            Simey Lameze Simey Lameze
            Dan Poltawski Dan Poltawski
            Mark Nelson Mark Nelson
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              12/Sep/16