Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55253

Choice activity missing Moodle internal test in lib.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.0.6, 3.1.2
    • Component/s: Choice
    • Labels:
    • Testing Instructions:
      Hide

      Manual Testing:

      1. Open the files and verify that they have been added
      2. Try to browse to the files using your favorite web browser and verify that nothing is displayed.
      Show
      Manual Testing: Open the files and verify that they have been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE

      Description

      Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
      defined('MOODLE_INTERNAL') || die();

      That check is missing from the lib.php

        Attachments

          Activity

            People

            Assignee:
            sbourget Stephen Bourget
            Reporter:
            sbourget Stephen Bourget
            Peer reviewer:
            Simey Lameze
            Integrator:
            Dan Poltawski
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Sep/16