[MDL-55255] Database activity missing Moodle internal test in some library files - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.1
Fix Version/s: 3.0.6, 3.1.2
Component/s: Database activity module
Labels:
- triaged

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Difficulty:
Easy
Testing Instructions:
Hide

Manual Testing:

Open the files and verify that they have been added

Try to browse to the files using your favorite web browser and verify that nothing is displayed.
Show
Manual Testing: Open the files and verify that they have been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.

Description

Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
defined('MOODLE_INTERNAL') || die();

That check is missing from the lib.php, locallib.php, and rsslib.php

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-55255_m32.patch
1 kB
20/Jul/16 1:34 PM

Activity

People

Assignee:: Stephen Bourget

Reporter:: Stephen Bourget

Peer reviewer:: Adrian Greeve

Integrator:: Dan Poltawski

Tester:: Simey Lameze

Participants:: Adrian Greeve, CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Simey Lameze, Stephen Bourget

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 16/Jul/16 12:57 PM

Updated:: 28/Jul/16 11:54 PM

Resolved:: 28/Jul/16 10:18 PM

Fix Release Date:: 12/Sep/16