Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55278

search/classes/area is not following the coding style guide

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.2
    • Component/s: Global search
    • Labels:
    • Testing Instructions:
      Hide
      1. Check that there are no references to search\area\ namespace
      2. Run phpunit and check that there are no failures
      3. Setup global search and index your site data
      4. Search and check that resutls are returned (nothign special to test, just that it works)
      Show
      Check that there are no references to search\area\ namespace Run phpunit and check that there are no failures Setup global search and index your site data Search and check that resutls are returned (nothign special to test, just that it works)
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55278_master

      Description

      As raised by Eloy Lafuente (stronk7), area is not an official core api, more info in https://docs.moodle.org/dev/Coding_style#Namespaces

      I understand that the are namespace classes should be located in search/classes/

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16