[MDL-55287] Search areas admin page ugly error when no search engine is selected - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Master Branch:
~~MDL-55287~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...dmonllao:MDL-55287_master
Testing Instructions:
Hide

Unset CFG->searchengine (to hack the DB + purge caches may be the fastest choice)

Go to admin/searchareas.php

You should see a warning stating "You have not selected any search engine"

Go to admin/settings.php?section=manageglobalsearch

Save changes so solr is stored as CFG->searchengine value

(only if you have php solr extension enabled) Disable your solr extension and restart apache

Go to admin/searchareas.php

You should see a warning stating "Engine solr is not installed"
Show
Unset CFG->searchengine (to hack the DB + purge caches may be the fastest choice) Go to admin/searchareas.php You should see a warning stating "You have not selected any search engine" Go to admin/settings.php?section=manageglobalsearch Save changes so solr is stored as CFG->searchengine value (only if you have php solr extension enabled) Disable your solr extension and restart apache Go to admin/searchareas.php You should see a warning stating "Engine solr is not installed"

I've accessed admin/searchareas.php before selecting any search engine and I've seen the following error:

{$a} not installed.

We should not show any error if no search engine is selected just disable the index/delete buttons.

Discovered while testing

MDL-55281 Solr requires hostname

is a regression caused by

MDL-53222 Revise admin settings/report for global search for improved usability

Participants:: CiBoT, Dan Poltawski, David Monllaó, Jun Pataleta, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo