Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55299

Single and double quotes encoded in HTML characters in downloaded files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course and enroll 1 student
      2. Create feedback in the course
      3. Add one short text question and one long text question to the feedback
      4. Login as student
      5. Do the feedback using this value for both questions: This is a "quoted" 'text' example.
      6. Login as teacher or admin
      7. Go to the feedback and go to the "Show responses" tab
        1. Check that in both questions the answer displays the single and double quotes correctly.
      8. Using the download table as form, download the table in all possible formats.
      9. Open de .csv file with some text editor
        1. Check that in both questions the double quote is duplicated and the single one no (This is a ""quoted"" 'text' example.)
      10. Open the .xlsx, .HTML, .ods and .pdf with the proper program
        1. Check that in all cases the single quotes and the double ones are displayed correctly in the answers.
      11. Open the .json file in a basic text editor
        1. Check that the file has the double quotes scaped like: "This is an \"example\" of text with 'some' quotes in it"

       

      Show
      Create a course and enroll 1 student Create feedback in the course Add one short text question and one long text question to the feedback Login as student Do the feedback using this value for both questions: This is a "quoted" 'text' example. Login as teacher or admin Go to the feedback and go to the "Show responses" tab Check that in both questions the answer displays the single and double quotes correctly. Using the download table as form, download the table in all possible formats. Open de .csv file with some text editor Check that in both questions the double quote is duplicated and the single one no (This is a ""quoted"" 'text' example.) Open the .xlsx, .HTML, .ods and .pdf with the proper program Check that in all cases the single quotes and the double ones are displayed correctly in the answers. Open the .json file in a basic text editor Check  that the file has the double quotes scaped like: "This is an \"example\" of text with 'some' quotes in it"  
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull Master Branch:
      MDL-55299-master
    • Sprint:
      Moppies Kanban

      Description

      In a feedback activity, on the show responses tab, the single and double quotes of the feedback's content are encoded as html characters when you download the files (xlsx, csv...)
      They appear fine on the page.
      They are stored already encoded in the DB, so what's missing is probably to revert them back to normal quotes / double quotes when generating the files.

      We noticed the error after upgrading an instance from 2.7 to 3.1, and it's still here on 3.1.1.

      Could be reproduced on the demo.moodle.net

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tusefomal Ferran Recio
              Reporter:
              FriedrichIII Pascal Cudré
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 5 minutes
                  3h 5m