Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55325

LTI external tool registration not working

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Expose your webserver on the internet using ngrok.

        ./ngrok http 80
        

      2. Set your config.php's $CFG->wwwroot to the http (or https, if you're using https) URL shown in ngrok's console.
      3. Go to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools
      4. Enter http://lti.tools/test/tp.php into the Tool URL... field in the Add tool panel.
      5. Click the Add button.
      6. Check out the page output.
      Show
      Expose your webserver on the internet using ngrok. ./ngrok http 80 Set your config.php's $CFG->wwwroot to the http (or https, if you're using https) URL shown in ngrok's console. Go to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools Enter http://lti.tools/test/tp.php into the Tool URL... field in the Add tool panel. Click the Add button. Check out the page output. The loading indicator goes away and the http://lti.tools/test/tp.php page loads up. There should be no JS error.
    • Workaround:
      Hide
      • After the loading indicator shows up, click the Manage tools breadcrumb and manually edit the external tool registration.
      • Or just manually create a tool by clicking the Manage external tool registrations link.
      Show
      After the loading indicator shows up, click the Manage tools breadcrumb and manually edit the external tool registration. Or just manually create a tool by clicking the Manage external tool registrations link.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55325-master

      Description

      The second step of external tool registration just shows a loading image. Checking out the JavaScript console, I can see the following:

      require.js:903 TypeError: a.indexOf is not a function(…)
      check @ require.js:903enable @ require.js:1180
      init @ require.js:786
      (anonymous function) @ require.js:1464

      Looks like it got broken after MDL-50937 got integrated.

      To reproduce:

      1. Expose your webserver on the internet using ngrok.

        ./ngrok http 80
        

      2. Set your config.php's $CFG->wwwroot to the http (or https, if you're using https) URL shown in ngrok's console.
      3. Go to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools
      4. Enter http://lti.tools/test/tp.php into the Tool URL... field in the Add tool panel.
      5. Click the Add button.
      6. Check out the page output.
      7. Expected:
      8. Actual
        • The loading indicator does not go away and there's nothing you can do.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16