Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55326

String API - moodledata folder - typo3temp - new files use wrong permissions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.12, 3.0.5, 3.1.5, 3.2.2, 3.3
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide
      1. Open the Moodle tempdir and find the typo3temp/cs/ folder within it
      2. Delete all files in it
      3. Run the attached test.php
      4. View the long list of the files in the directory and check permissions
        1. Ensure that they match those found in the moodle filedir
      Show
      Open the Moodle tempdir and find the typo3temp/cs/ folder within it Delete all files in it Run the attached test.php View the long list of the files in the directory and check permissions Ensure that they match those found in the moodle filedir
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-55326-master

      Description

      Just seen in /lib/classes/text.php:

      // Default mask for Typo
      $GLOBALS['TYPO3_CONF_VARS']['BE']['fileCreateMask'] = $CFG->directorypermissions;

      Should it not rather use $CFG->filepermissions?

      The files created in this class seem to be set using wrong permissions.
      /moodledata/temp/typo3temp/cs/cscase_utf-8.tbl
      /moodledata/temp/typo3temp/cs/csascii_utf-8.tbl

      A script of mine checks permissions inside the moodledata folder (always be readable and writable by the apache user), so I found out about those two.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            poggenpohlda Daniel Poggenpohl
            Peer reviewer:
            Jake Dallimore
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/May/17