Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55352

Label values on series should always prevail when displaying a chart

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Other
    • Testing Instructions:
      Hide
      1. Download the attached script.
      2. Open the browser and run it.
      3. Mouse over the violet bars and make sure they have custom tool tips ($ before the value)
      4. Now, mouse over the orange bars, make sure they have not custom tool tips (should not have $)
      5. Click on Show chart data link to expand the data table.
      6. Make sure the values of Sales (With Series Labels) column are displayed with $
      7. Make sure the values of Expenses (No Series Labels - Default) column are NOT displayed with $.
      8. Check nightly results, make sure there are no failures for mod_choice and mod_feedback.
      Show
      Download the attached script. Open the browser and run it. Mouse over the violet bars and make sure they have custom tool tips ($ before the value) Now, mouse over the orange bars, make sure they have not custom tool tips (should not have $) Click on Show chart data link to expand the data table. Make sure the values of Sales (With Series Labels) column are displayed with $ Make sure the values of Expenses (No Series Labels - Default) column are NOT displayed with $ . Check nightly results, make sure there are no failures for mod_choice and mod_feedback.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55352-master

      Description

      Currently, a chart_series can define custom labels for its values but on display the custom label is appended to the value. This shouldn't be the case as it means that we can never replace the value with something more custom (e.g. 1000000 to 1mil).

      This issue should change it so that in both htmltable and chartjs output the raw series value is only used when no labels have been defined.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Dan Poltawski
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16