[MDL-55360] Unable to create workshop instance with empty grades to pass - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.1
Fix Version/s: 3.0.6, 3.1.2
Component/s: Workshop
Labels:
- ci
- triaged

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Master Branch:
~~MDL-55360~~-master-workshopgradepass
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/d1a3ea62ef...MDL-55360-master-workshopgradepass
Testing Instructions:

Hide

Attempt to create a workshop with leaving all fields in their default values. The workshop name should be the only field you need to fill.

Run workshop behat tests --tags=@mod_workshop as new tests for this issue were added.

Show
Attempt to create a workshop with leaving all fields in their default values. The workshop name should be the only field you need to fill. Run workshop behat tests --tags=@mod_workshop as new tests for this issue were added.

Description

This seems to be a regression of ~~MDL-51806~~. I am no longer able to create a new workshop instance with the fields "Submission grade to pass" or "Assessment grade to pass" left empty. The validation fails with "You must enter a number here".

Attachments

Issue Links

is a regression caused by

MDL-51806 Workshop: cannot save edited settings when using comma as a decimal separator

Closed

Activity

People

Assignee:: David Mudrák (@mudrd8mz)

Reporter:: David Mudrák (@mudrd8mz)

Peer reviewer:: Jake Dallimore

Integrator:: Dan Poltawski

Tester:: Mark Nelson

Participants:: CiBoT, Dan Poltawski, David Mudrák (@mudrd8mz), Jake Dallimore, Mark Nelson, Rajesh Taneja

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 28/Jul/16 5:12 AM

Updated:: 25/Aug/16 1:03 PM

Resolved:: 05/Aug/16 12:02 AM

Fix Release Date:: 12/Sep/16

Time Tracking

Estimated:

Remaining:

Logged:

2h 55m