Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55382

Upload PDF Quicklist comments Sort by Alphabetical Order

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.15, 2.8.12, 2.9.7, 3.0.5, 3.1, 3.4
    • Fix Version/s: 3.3.5, 3.4.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as a teacher
      2. Access one of your courses (create a course and enrol a user if you don't have any user with teacher role in a course)
      3. You will need a student so enrol a user as a student if you don't have any
      4. Create an assignment with "Annotate PDF" feedback type enabled.
      5. Grade a student and use the "comment" tool (the first one in the header of the pdf drawing area) to add some text comments.
        1. Comment 1: "GGGG in the middle"
        2. Comment 2: "AAAA at the top"
        3. Comment 3: "ZZZ at the bottom".
      6. Add each comment to the quick list in the same order listed here. (to add a comment to the quick list, you select the comment, then click on the menu icon in the top right and choose "Add to quick list".)
      7. Create a new blank comment.
      8. Open the comment menu and verify the quicklist comments are listed in alphabetical order.
      9. Proceed to the next student.
      10. Create a new blank comment.
      11. Open the comment menu and verify the quicklist comments are listed in alphabetical order.
      Show
      Log in as a teacher Access one of your courses (create a course and enrol a user if you don't have any user with teacher role in a course) You will need a student so enrol a user as a student if you don't have any Create an assignment with "Annotate PDF" feedback type enabled. Grade a student and use the "comment" tool (the first one in the header of the pdf drawing area) to add some text comments. Comment 1: "GGGG in the middle" Comment 2: "AAAA at the top" Comment 3: "ZZZ at the bottom". Add each comment to the quick list in the same order listed here. (to add a comment to the quick list, you select the comment, then click on the menu icon in the top right and choose "Add to quick list".) Create a new blank comment. Open the comment menu and verify the quicklist comments are listed in alphabetical order. Proceed to the next student. Create a new blank comment. Open the comment menu and verify the quicklist comments are listed in alphabetical order.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55382-master

      Description

      Lecturers at my institution have asked if the Quicklist comments for marking in the Upload PDF --> Annototate PDF marking system could be organisaed by alphabetical order as opposed to creation date.

      As a result, I have made the following code change which has not been fully tested as of yet.

      Inside the folder: www\mod\assign\feedback\editpdf\classes

      under 'comments_quick_list.php'

      I have changed the PHP to include:

      usort($records, function($a, $b)

      {return strcasecmp($a->rawtext, $b->rawtext);}

      );

      after line 45

      If this feature is something people marking work find easier to use over the current order of creation date, then please include the code change to core Moodle. Alternatively, maybe an option can be added to the admin configuration for Upload PDF Quickcomments that selects sort order. This code has been added to Moodle 2.6.11.

        Attachments

        1. MDL-55382.xlsx
          6.14 MB
          Janelle Barcega

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                19/Mar/18