Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55398

Feedback activity missing Moodle internal test in lib.php

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.1.1
    • 3.0.6, 3.1.2
    • Feedback
    • MOODLE_31_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-55398_m32v1
    • Easy
    • Hide

      Manual Testing:

      • Open the file and verify that the check has been added
      • Try to browse to the files using your favorite web browser and verify that nothing is displayed.
      Show
      Manual Testing: Open the file and verify that the check has been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.

    Description

      Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
      defined('MOODLE_INTERNAL') || die();

      That check is missing from lib.php

      Attachments

        Activity

          People

            sbourget Stephen Bourget
            sbourget Stephen Bourget
            Jake Dallimore Jake Dallimore
            Dan Poltawski Dan Poltawski
            Ryan Wyllie Ryan Wyllie
            Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              12/Sep/16