Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55398

Feedback activity missing Moodle internal test in lib.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.0.6, 3.1.2
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      Manual Testing:

      • Open the file and verify that the check has been added
      • Try to browse to the files using your favorite web browser and verify that nothing is displayed.
      Show
      Manual Testing: Open the file and verify that the check has been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-55398_m32v1

      Description

      Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
      defined('MOODLE_INTERNAL') || die();

      That check is missing from lib.php

        Attachments

          Activity

            People

            • Assignee:
              sbourget Stephen Bourget
              Reporter:
              sbourget Stephen Bourget
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Dan Poltawski
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Sep/16