[MDL-55398] Feedback activity missing Moodle internal test in lib.php - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.1
Fix Version/s: 3.0.6, 3.1.2
Component/s: Feedback
Labels:
- ci
- triaged

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
https://github.com/sbourget/moodle.git
Pull Master Branch:
~~MDL-55398~~_m32v1
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...sbourget:MDL-55398_m32v1
Difficulty:
Easy
Testing Instructions:
Hide

Manual Testing:

Open the file and verify that the check has been added

Try to browse to the files using your favorite web browser and verify that nothing is displayed.
Show
Manual Testing: Open the file and verify that the check has been added Try to browse to the files using your favorite web browser and verify that nothing is displayed.

Description

Most moodle internal scripts like lib.php and locallib.php usually begin with at test to prevent direct script access like:
defined('MOODLE_INTERNAL') || die();

That check is missing from lib.php

Attachments

Activity

People

Assignee:: Stephen Bourget

Reporter:: Stephen Bourget

Peer reviewer:: Jake Dallimore

Integrator:: Dan Poltawski

Tester:: Ryan Wyllie

Participants:: CiBoT, Dan Poltawski, Jake Dallimore, Ryan Wyllie, Stephen Bourget

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 02/Aug/16 4:52 PM

Updated:: 12/Aug/16 1:48 AM

Resolved:: 12/Aug/16 1:48 AM

Fix Release Date:: 12/Sep/16