Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55449

Remove support for message objects as stdClass

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as a user and go to the messages section (Speech bubble at the top).
      2. Send a message to another user.
      3. Log in as that user.
      4. Confirm that a message is received.
      5. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).
      Show
      Log in as a user and go to the messages section (Speech bubble at the top). Send a message to another user. Log in as that user. Confirm that a message is received. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55449-master

      Description

      Remove the debugging message in lib/classes/message/manager.php send_message when event data is passed as a stdClass.

      Throw a coding exception instead (the logic for the coding exception is there already, so it just needs to be removed from the allowed types.

      Tip: Look for "MDL-55449" in codebase and you'll find a number of places (both @todo and TODO) pointing to places and changes expected.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              amanda.doughty Amanda Doughty
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m