Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55449

Remove support for message objects as stdClass

    XMLWordPrintable

Details

    • MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • MDL-55449-master
    • Hide
      1. Log in as a user and go to the messages section (Speech bubble at the top).
      2. Send a message to another user.
      3. Log in as that user.
      4. Confirm that a message is received.
      5. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).
      Show
      Log in as a user and go to the messages section (Speech bubble at the top). Send a message to another user. Log in as that user. Confirm that a message is received. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).

    Description

      Remove the debugging message in lib/classes/message/manager.php send_message when event data is passed as a stdClass.

      Throw a coding exception instead (the logic for the coding exception is there already, so it just needs to be removed from the allowed types.

      Tip: Look for "MDL-55449" in codebase and you'll find a number of places (both @todo and TODO) pointing to places and changes expected.

      Attachments

        Issue Links

          has a non-specific relationship to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-47779 Review TODO with associated MDL's

          • Minor - Minor loss of function where workaround is possible
          • Open
          has to be done after

          Improvement - An enhancement to an existing Moodle feature. MDL-47162 Add course id to message eventdata

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55448 Remove support for message objects as stdClass

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              abgreeve Adrian Greeve
              amanda.doughty Amanda Doughty
              Carlos Escobedo Carlos Escobedo
              Andrew Lyons Andrew Lyons
              Anna Carissa Sadia Anna Carissa Sadia
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                3/Dec/18

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m