Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55449

Remove support for message objects as stdClass

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.6
    • 3.6
    • Messages
    • MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • MDL-55449-master
    • Hide
      1. Log in as a user and go to the messages section (Speech bubble at the top).
      2. Send a message to another user.
      3. Log in as that user.
      4. Confirm that a message is received.
      5. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).
      Show
      Log in as a user and go to the messages section (Speech bubble at the top). Send a message to another user. Log in as that user. Confirm that a message is received. While sending messages confirm that there are no errors (Try looking in the developer console in the network tab and check the response after sending a message).

      Remove the debugging message in lib/classes/message/manager.php send_message when event data is passed as a stdClass.

      Throw a coding exception instead (the logic for the coding exception is there already, so it just needs to be removed from the allowed types.

      Tip: Look for "MDL-55449" in codebase and you'll find a number of places (both @todo and TODO) pointing to places and changes expected.

            abgreeve Adrian Greeve
            amanda.doughty Amanda Doughty
            Carlos Escobedo Carlos Escobedo
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.