Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55453

Fix incorrect usage of js_send_uncached

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4, 3.1.1
    • Fix Version/s: 3.0.6, 3.1.2
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Can use cURL to confirm fix, examples:

      curl -s -D - wwwroot/lib/requirejs.php/-1/core/first.js -o /dev/null
      curl -s -D - wwwroot/lib/javascript.php/-1/lib/requirejs/jquery-private.js -o /dev/null
      

      Should return correct headers like one of these:

      Content-Disposition: inline; filename="requirejs.php"
      Content-Disposition: inline; filename="javascript.php"
      

      Instead of something like:

      Content-Disposition: inline; filename="7984b0a0e139cabadb5afc7756d473fb34d23819"
      

      Show
      Can use cURL to confirm fix, examples: curl -s -D - wwwroot/lib/requirejs.php/-1/core/first.js -o /dev/null curl -s -D - wwwroot/lib/javascript.php/-1/lib/requirejs/jquery-private.js -o /dev/null Should return correct headers like one of these: Content-Disposition: inline; filename="requirejs.php" Content-Disposition: inline; filename="javascript.php" Instead of something like: Content-Disposition: inline; filename="7984b0a0e139cabadb5afc7756d473fb34d23819"
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55453-master

      Description

      In the following locations:

      • lib/requirejs.php:144 (At the end of the file)
      • lib/javascript.php:109 (At the end of the file)

      The variable $etag is being passed in, but the function signature does not accept one. In both cases, the $etag parameter should just be removed.

      Not really sure if this actually harms anything or not, just noticed it.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Sep/16