Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55476

Remove loginpasswordautocomplete option

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisite: install mailcatcher.

      1. Go to Site administration > Security > HTTP security
      2. Check that the "Prevent password autocompletion on login form" setting is not there.
      3. Login to your database and in the mdl config table, check that loginpasswordautocomplete is not present.
      4. Logout and login and make sure there are no errors.
      5. Add the login block to the site homepage.
      6. Logout and use the login block to login.
      7. Logout and click forgot password.
      8. Search for your username.
      9. Check mailcatcher for password reset link and click it.
      10. Check that there were no errors and enter new password.
      Show
      Prerequisite: install mailcatcher. Go to Site administration > Security > HTTP security Check that the "Prevent password autocompletion on login form" setting is not there. Login to your database and in the mdl config table, check that loginpasswordautocomplete is not present. Logout and login and make sure there are no errors. Add the login block to the site homepage. Logout and use the login block to login. Logout and click forgot password. Search for your username. Check mailcatcher for password reset link and click it. Check that there were no errors and enter new password.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55476-master

      Description

      There's currently a loginpasswordautocomplete option in moodle. This simply appends autocomplete="off" to the password field in the form. As has been previously discussed this does nothing at all.

      We should remove the feature

      Site administration ▶︎ Security ▶︎ HTTP security

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jadet23 Jade Telford
              Reporter:
              johno John Okely
              Peer reviewer:
              Adrian Greeve Adrian Greeve
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              cameron1729 cameron1729
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17