Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55510

Alfresco repository is prompted as missing on every upgrade

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 3.2
    • 3.2
    • Repositories
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-55510-master
    • Hide
      1. Install Moodle 3.1
      2. Change code to master
      3. Upgrade to master
      4. VERIFY: there is a message about repository_alfresco being deleted and is standard
      5. Edit your version.php to force another upgrade
      6. Run upgrade
      7. VERIFY: that upgrade doesn't mention repository_alfresco anymore
      1. Install Moodle 3.1
      2. Change code to master
      3. Run the upgrade UNTIL you get to the plugins check
      4. Verify: it mentions repository_alfresco removed
      5. Download alfresco from the GitHub repository at https://github.com/moodlehq/moodle-repository_alfresco and install it into your repository directory
      6. Refresh the plugins check
      7. VERIFY: there is not 'to be removed' mention about alfresco (or 'to be installed', should be 'to be upgraded')
      8. VERIFY: when you search for alfresco it the roles edit screen that the capabilities are still listed
      Show
      Install Moodle 3.1 Change code to master Upgrade to master VERIFY: there is a message about repository_alfresco being deleted and is standard Edit your version.php to force another upgrade Run upgrade VERIFY: that upgrade doesn't mention repository_alfresco anymore Install Moodle 3.1 Change code to master Run the upgrade UNTIL you get to the plugins check Verify: it mentions repository_alfresco removed Download alfresco from the GitHub repository at https://github.com/moodlehq/moodle-repository_alfresco and install it into your repository directory Refresh the plugins check VERIFY: there is not 'to be removed' mention about alfresco (or 'to be installed', should be 'to be upgraded') VERIFY: when you search for alfresco it the roles edit screen that the capabilities are still listed

    Description

      Something not handled properly in MDL-49533. As reported by marina and noticed by me too.

      I think we need to do unset_all_config_for_plugin conditionally - although its not clear to me what the point of a is_deleted_standard_plugin if that doesn't prevent it, so maybe there is a typo or something else.

      Attachments

        Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-49533 Move alfresco repository to plugins DB

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Simey Lameze Simey Lameze
              David Monllaó David Monllaó
              Adrian Greeve Adrian Greeve
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16