Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55519

Clicking button "Unlock completion options" in 'assign' settings resets the maximum points to the default

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course with completion tracking turned on.
      2. Add an assignment activity.
        • Set Grade > Grade > Maximum grade - to Something different to 100.
        • Set Activity completion > Completion tracking - Show activity as complete when conditions are met.
        • Set Activity completion > Require grade - Student must receive a grade to complete this activity.
      3. Grade a student.
      4. Edit the settings for the assignment.
        • Expand Grade and see that the maximum grade is greyed out.
        • Expand Activity completion. There should me a label that says that completion options are locked. Click the button "Unlock completion options"
      5. Expand grade if it isn't expanded already.
        • The Maximum grade should still be what you set it and not 100 (This was defaulting back to 100 before the patch).
      Show
      Create a course with completion tracking turned on. Add an assignment activity. Set Grade > Grade > Maximum grade - to Something different to 100. Set Activity completion > Completion tracking - Show activity as complete when conditions are met. Set Activity completion > Require grade - Student must receive a grade to complete this activity. Grade a student. Edit the settings for the assignment. Expand Grade and see that the maximum grade is greyed out. Expand Activity completion. There should me a label that says that completion options are locked. Click the button "Unlock completion options" Expand grade if it isn't expanded already. The Maximum grade should still be what you set it and not 100 (This was defaulting back to 100 before the patch).
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-55519-master
    • Sprint:
      3.2 Sprint 6

      Description

      This issue was reported before MDL-55520 and some of it was fixed there. Still a problem remains, here are reproduction steps:

      1. # In an existing course, create a new assign element. Set max points to a value != 100 (in my case, 42), and leave activity tracking off.
      2. Check that the max. points are 42 - OK.
      3. Re-open the exercise settings, turn on tracking for "must have received a grade", save. Reopen to validate that points are still at 42.
      4. Grade a student with (for example) 21 points and check it is shown as "21 / 42" - OK.
      5. Reopen the assign settings and turn activity tracking off. You first need to press a button to be able to do so, which will cause the page to reload - and lo and behold, the max points are now shown as 100. Ignore this, turn of tracking, and save. The grade is still 21 / 42, although grading stated that max points were 100 - if I had acted on this, who knows what would have happened to the actual grades...

      -----------
      Original description:

      On our system (Moodle 3.1.1+), there are multiple assign activities using rubric grading in the course with graded student submissions (e.g., "15 out of 15 points"). The teacher turned on "completion tracking" for the course, and activated automatic completion on "require view" and "require grade" (option 1, "must receive a grade"). After saving the modified activity, the maximum points possible was reset to 100 (the default) without any request for this - it was supposed to stay at 15. Thus users now had "15 out of 100 points".

      FULL STEPS

      1. Create a course with completion tracking turned off.
      2. Add some users and at least one assignment ("assign") using Rubric grading. Set the points possible to some other value than the default, for example 20.
      3. Provide some student submissions and grade them.
      4. Turn on completion tracking for the course.
      5. Edit the assignment by turning on activity completion. Before saving, check that "Maximum grade" in the Grade section is greyed out "because some grades have already been awarded", and still has your value set in step 2 (20).
      6. Save the edited assignment.
      7. Directly after (or possibly only after cron has run?), open the grades. Where they said something like "7 / 20", they now show "7 / 100" - or whatever the site-wide "grade point default is".

      WHAT I EXPECTED
      I expected that the maximum grade possible would not in any way be affected by turning on the activity's completion tracking. Thus, 7 / 20 should remain 7 / 20, not 7 / 100 (or whatever).

      WHAT ACTUALLY HAPPENS
      The awarded points stay the same (e.g., 7 / 20 will now be something like 7 / 100, not 35 / 100) and thus the total points achieved by the students are unchanged. However, if the graders continue using the rubric without noticing the new "maximum grade", the next student will receive "100 / 100" points instead of the original "maximum of 20 points", skewing the course points total and the grade determination

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Nov/16