Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55592

Consumer key and secret are not cleared when adding a cartridge

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. You need to have your Moodle instance exposed over the internet (e.g. using ngrok)
      2. Login as Site Admin
      3. Go to: "Site administration / Plugins / Activity modules / External tool / Manage tools"

      Test

      1. Paste this "https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml" URL in the Tool URL field 
      2. Press "Add"
      3. Enter "ABCD" as the Consumer key and "EFGH" as the Shared secret
      4. Save changes
      5. Paste the same URL in the Tool URL field (don't leave the page)
      6. Press "Add"
      7. Verify the "Enter your consumer key and shared secret" form shows and the "Consumer key" and "Shared secret" fields are blank.
      Show
      Setup You need to have your Moodle instance exposed over the internet (e.g. using ngrok) Login as Site Admin Go to: "Site administration / Plugins / Activity modules / External tool / Manage tools" Test Paste this "https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml" URL in the Tool URL field  Press "Add" Enter "ABCD" as the Consumer key and "EFGH" as the Shared secret Save changes Paste the same URL in the Tool URL field (don't leave the page) Press "Add" Verify the "Enter your consumer key and shared secret" form shows and the "Consumer key" and "Shared secret" fields are blank.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-55592-master

      Description

      Reproduction steps
      1. Go to Site administration > Plugins > Activity modules > External tool > Manage tool types
      2. Paste a cartridge url into the box (shared from another moodle instance is fine, or from eduappcenter)
      3. Click add
      4. Put a secret and key
      5. Paste another cartridge url (the same one probably works)
      6. Click add
      7. The secret and key should be empty but remain from before.

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            johno John Okely
            Peer reviewer:
            Peter Dias
            Integrator:
            Jun Pataleta
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h