Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55617

Possible fatal error in import script if browser back button is used

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.15, 3.1.1
    • Fix Version/s: 3.0.6, 3.1.2
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      Testing backup and restore is not broken

      1. Perform a normal backup, there should be no errors and a file should be generated.
      2. Perform a restore, there should be no errors and the content should appear
      3. Perform an import, the selected content should appear in the target course.

      Testing the fix works

      1. Perform a course import as normal until it has completed on the '5. Perform import' step
      2. Use the browser back button to go back to the '4. Confirmation and review' step
      3. Press the 'Perform import' button
      4. There should not be a fatal error, the import should fail gracefully.
      Show
      Testing backup and restore is not broken Perform a normal backup, there should be no errors and a file should be generated. Perform a restore, there should be no errors and the content should appear Perform an import, the selected content should appear in the target course. Testing the fix works Perform a course import as normal until it has completed on the '5. Perform import' step Use the browser back button to go back to the '4. Confirmation and review' step Press the 'Perform import' button There should not be a fatal error, the import should fail gracefully.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      It is possible to get a fatal error on the course import page using the following steps:

      1. Perform a course import as normal until it has completed on the '5. Perform import' step
      2. Use the browser back button to go back to the '4. Confirmation and review' step
      3. Press the 'Perform import' button

      There will now be a Fatal error with the following message:

      Fatal error: Call to a member function is_checksum_correct() on boolean in D:\moodlesource\moodledev2\backup\util\dbops\backup_controller_dbops.class.php on line 109

        Attachments

          Activity

            People

            Assignee:
            nmagill Neill Magill
            Reporter:
            nmagill Neill Magill
            Peer reviewer:
            Dan Poltawski
            Integrator:
            David Monllaó
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Sep/16