Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55626

clean theme missing desktop-first-column css class for span9 in columns3 & columns2 layouts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.7, 3.0.5, 3.1
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Select and use Clean theme throughout these tests:

      Note that this is only a regression testing. Margins should look the same before and after this patch.

      TEST A - three column layout (includes the Secure layout)

      1. Login and go to the Frontpage and make sure that there are at least three blocks displayed correctly either side of the main content.
      2. Check also to see that the blocks on the left are equally spaced from the edge of the page to the side of the browser window, as they are on the right.

      TEST B - two column layout.

      1. Go to Site Administration > Notifications and verify the page is set out as it should be with blocks on the left.
        PLEASE NOTE: Since this test will require testing in RTL it may be easier if you understand the way the blocks work. So 'Pre' in this case mean 'before main content' and so in RTL (Right to Left) Pre will be on the RIGHT.
        So what is happening in the layout, is that the containers carrying the 'side pre' blocks, slide from left to right. There's no JavaScript trickery here! It is all done with CSS.
      2. Change language to a RTL one like Hebrew or Arabic and check that the column that was previously on the left is now on the right but displayed correctly with a margin between the main content and the blocks and also from the blocks to the edge of the browser window.
      Show
      Select and use Clean theme throughout these tests: Note that this is only a regression testing. Margins should look the same before and after this patch. TEST A - three column layout (includes the Secure layout) Login and go to the Frontpage and make sure that there are at least three blocks displayed correctly either side of the main content. Check also to see that the blocks on the left are equally spaced from the edge of the page to the side of the browser window, as they are on the right. TEST B - two column layout. Go to Site Administration > Notifications and verify the page is set out as it should be with blocks on the left. PLEASE NOTE: Since this test will require testing in RTL it may be easier if you understand the way the blocks work. So 'Pre' in this case mean 'before main content' and so in RTL (Right to Left) Pre will be on the RIGHT. So what is happening in the layout, is that the containers carrying the 'side pre' blocks, slide from left to right. There's no JavaScript trickery here! It is all done with CSS. Change language to a RTL one like Hebrew or Arabic and check that the column that was previously on the left is now on the right but displayed correctly with a margin between the main content and the blocks and also from the blocks to the edge of the browser window.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-55626-MASTER

      Description

      I remember Andrew Nicols querying this when changes where made originally. I said it did not matter, but I have found out since that it does matter, as without the class selector it can break the layout.

      All this change does is removes the left margin from the page when blocks are present on a three column page in LTR languages and on a 2 column page when in RTL. It is this margin that can cause the page to malfunction, sending some blocks to the bottom of the page.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Nov/16