Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55657

All passwords are acting as passwordunmask

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as admin
      2. Set theme to noname
      3. Navigate to Site administration -> Users -> Accounts -> Add a new user
        1. Confirm that the passwordunmask is present and works
      4. Navigate to User menu -> Preferences -> Change password
        1. Confirm that the password field is not unmaskable
      5. Repeat on clean theme
      Show
      Login as admin Set theme to noname Navigate to Site administration -> Users -> Accounts -> Add a new user Confirm that the passwordunmask is present and works Navigate to User menu -> Preferences -> Change password Confirm that the password field is not unmaskable Repeat on clean theme
    • Affected Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-55657-master

      Description

      Both password, and passwordunmask share the theme/noname/templates/core_form/element-password.mustache template.
      The JS in that template converts a standard password element to a passwordunmask field and currently does so unconditionally.

      Either this should be conditional, or should be moved to a separate template.
      Note: MDL-53048 seeks to rewrite passwordunmask so you may wish to just remove the existing content, or defer til that issue.

        Attachments

          Activity

            People

            • Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Damyon Wiese
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: