[MDL-55741] phpunit_util::reset_all_data does not clear the cache in get_log_manager - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.0.5, 3.1.1, 3.2
Fix Version/s: 3.0.6, 3.1.2
Component/s: Logging, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-55741~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-55741
Testing Instructions:

Hide

Verify that all the core unit tests still pass after this change.

Show
Verify that all the core unit tests still pass after this change.

Description

We had a nasty case of tool_log_manager_testcase::test_get_log_manager failing, due to a completely unrelated tests in an OU plugin that was testing that certain things were logged properly in one of its unit tests.

The fix is simple, and I present it here for integration.

Attachments

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Rajesh Taneja

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Rajesh Taneja, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 27/Aug/16 7:48 AM

Updated:: 01/Sep/16 9:46 PM

Resolved:: 01/Sep/16 9:46 PM

Fix Release Date:: 12/Sep/16