[MDL-55808] Search glossary entries with ratings enabled doesn't work - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Login as a teacher in a course

Create a Glossary activity

Expand the "Ratings" section of the form and set "Aggregate type" to "Count of ratings"

Click "Save and display"

Add one or more glossary entries.

Go to back to the glossary's main page

Perform a search matching at least one of the entries that you created.

Confirm that the correct entries are displayed in the search results.
Show
Login as a teacher in a course Create a Glossary activity Expand the " Ratings " section of the form and set " Aggregate type " to " Count of ratings " Click " Save and display " Add one or more glossary entries. Go to back to the glossary's main page Perform a search matching at least one of the entries that you created. Confirm that the correct entries are displayed in the search results.
Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
git://github.com/juancs/moodle.git
Pull Master Branch:
~~MDL-55808~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...juancs:MDL-55808_master

To reproduce:

What you get is:

If the term searched is in the entry added you get "No entries found in this section" --> WRONG
If the term searched is not in the entry added you get "Coding error detected, it must be fixed by a programmer: moodle_database::get_in_or_equal() does not accept empty arrays" --> WRONG

is a regression caused by

MDL-49231 mod_glossary_xxx services

Participants:: Andrew Nicols, Ankit Agarwal, CiBoT, Damyon Wiese, Frédéric Massart, Ilya Zhuykov, Jake Dallimore, Juan Segarra Montesinos, Jun Pataleta, Rayna Mae Jayco

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias