Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55808

Search glossary entries with ratings enabled doesn't work

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as a teacher in a course
      2. Create a Glossary activity
      3. Expand the "Ratings" section of the form and set "Aggregate type" to "Count of ratings"
      4. Click "Save and display"
      5. Add one or more glossary entries.
      6. Go to back to the glossary's main page
      7. Perform a search matching at least one of the entries that you created.
        • Confirm that the correct entries are displayed in the search results.
      Show
      Login as a teacher in a course Create a Glossary activity Expand the " Ratings " section of the form and set " Aggregate type " to " Count of ratings " Click " Save and display " Add one or more glossary entries. Go to back to the glossary's main page Perform a search matching at least one of the entries that you created. Confirm that the correct entries are displayed in the search results.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55808_master
    • Pull Master Diff URL:
    • Sprint:
      3.4 Sprint 5

      Description

      To reproduce:

      • Create a glossary
      • In ratings section choose an Aggregation method other than "No ratings"
      • Add a new entry with a concept and definition
      • Go to the glossary page and see the entry
      • Now perform a search

      What you get is:

      • If the term searched is in the entry added you get "No entries found in this section" --> WRONG
      • If the term searched is not in the entry added you get "Coding error detected, it must be fixed by a programmer: moodle_database::get_in_or_equal() does not accept empty arrays" --> WRONG

        Attachments

          Issue Links

          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-49231 mod_glossary_xxx services

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jsegarra Juan Segarra Montesinos
              Reporter:
              jsegarra Juan Segarra Montesinos
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Jun Pataleta
              Tester:
              Rayna Mae Jayco
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18