Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55827

PHP7.1 incorrect number of arguments can no longer be suppressed with @

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.1, 3.2
    • Fix Version/s: 3.2
    • Component/s: Filters
    • Labels:
    • Sprint:
      3.2 Sprint 5

      Description

      we have failures on PHP 7.1 similar to this (see full unittest results on issue MDL-55120):

      8) core_moodlelib_testcase::test_clean_param_array
      Error: Too few arguments to function clean_param_array(), 1 passed in /home/moodle/moodles/m/moodle/lib/tests/moodlelib_test.php on line 428 and at least 2 expected
       
      /home/moodle/moodles/m/moodle/lib/moodlelib.php:752
      /home/moodle/moodles/m/moodle/lib/tests/moodlelib_test.php:428
      /home/moodle/moodles/m/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_moodlelib_testcase lib/tests/moodlelib_test.php
      

        Attachments

          Activity

            People

            Assignee:
            marina Marina Glancy
            Reporter:
            marina Marina Glancy
            Peer reviewer:
            Simey Lameze
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            John Okely
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16