Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55837

Deprecate "base and canvas" themes

    XMLWordPrintable

Details

    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-55837-master
    • Hide

      1) If there is any base/canvas based theme installed in the site, both CLI and web upgrade won't happen, asking for the dependencies to be satisfied before continuing.
      2) If there isn't any base/canvas theme installed... upgrade will happen and there won't be anything to verify, but maybe check there aren't config settings belonging to those 2 themes.

      Show
      1) If there is any base/canvas based theme installed in the site, both CLI and web upgrade won't happen, asking for the dependencies to be satisfied before continuing. 2) If there isn't any base/canvas theme installed... upgrade will happen and there won't be anything to verify, but maybe check there aren't config settings belonging to those 2 themes.

    Description

      Since we are adding a new theme in 3.2 and we don't test in base or canvas - we should deprecate them (move to plugins dir). I doubt base and canvas have aged well since we don't test in them and we have been adding bootstrap classes directly to the DOM for a while now.

      Attachments

        Issue Links

          duplicates

          Improvement - An enhancement to an existing Moodle feature. MDL-51144 Deprecate use of the `base` theme

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-56099 Create plugin db entries for base and canvas themes

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Ryan Wyllie Ryan Wyllie
              David Monllaó David Monllaó
              Marina Glancy Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              4 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16