Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55858

Remove unsubscribe link from notification email in forum with forced subscription

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a new course and enrol a student
      2. Create four forums in the course - one of each subscription type
      3. Subscribe your user to each forum (it is possible to subscribe a user to a subscription disabled forum)
      4. Post in each forum and ignore maxeditingtime
      5. Configure your site to use mailcatcher (or have working e-mail)
      6. Run the forum cron task:

        php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task"
        

      7. Look at the footers in each received e-mail and confirm:
        1. Optional: Subscriptions links are present
        2. Automatic: Subscriptions links are present
        3. Forced: Subscriptions links are not present
        4. Disabled: Subscriptions links are not present

      The case where users are subscribed to subscription disabled forums is very rare. I didn't feel it was worth doing adding the links back in these cases.

      Show
      Create a new course and enrol a student Create four forums in the course - one of each subscription type Subscribe your user to each forum (it is possible to subscribe a user to a subscription disabled forum) Post in each forum and ignore maxeditingtime Configure your site to use mailcatcher (or have working e-mail) Run the forum cron task: php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task" Look at the footers in each received e-mail and confirm: Optional: Subscriptions links are present Automatic: Subscriptions links are present Forced: Subscriptions links are not present Disabled: Subscriptions links are not present The case where users are subscribed to subscription disabled forums is very rare. I didn't feel it was worth doing adding the links back in these cases.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-55858-master

      Description

      Steps to reproduce:

      1. Create a forum with forced subscription and post in it.
      2. View the forum post notification email.

      Expected result:

      Ideally the email should not contain the links 'Unsubscribe from this forum', 'Unsubscribe from this discussion' and 'Change your forum digest preferences'. However, if this is unavoidable, the links should lead to a page with a meaningful message.

      Actual result:

      Unsubscribe links in the email lead to the forum page with message 'Everyone is now subscribed to this forum'.

        Attachments

          Activity

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16