Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55866

Remember editor disabled setting on a per-activity setting

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a new database activity and add some fields to it:
        1. Name (text input)
        2. Recommend (checkbox with option Yes)
      2. Open the templates editor
      3. For each type of HTML template:
        1. Confirm that you can disable the HTML editor
        2. Confirm that you can re-enable the HTML editor
        3. Confirm that after setting each state you can switch to another page and upon return, the editor state is remembered
        4. Confirm that the editor state persists between session
        5. Confirm that the editor state persists when a different user views the template
        6. Confirm that the editor state is specific to the type of template being edited
        7. Confirm that a confirmation dialogue is shown when re-enabling the HTML editor
      4. Navigate to the "List view" template editor
      5. Disable the HTML editor
      6. Enter an open tag in the Header section and a corresponding close tag in the Footer section, e.g.
        Header:

        <table class="table table-bordered table-hover table-condensed">
        <thead>
        <tr>
        <th>Name</th>
        <th>Recommend</th>
        <th>Author</th>
        <th>Controls</th>
        </tr>
        </thead>
        <tbody>
        

        Body:

        <tr class="##approvalstatus##">
        <td>[[Name]]</td>
        <td>[[Recommended]]</td>
        <td>##user##</td>
        <td>##edit##  ##more##  ##delete##  ##approve##  ##disapprove##  ##export##</td>
        </tr>
        

        Footer:

        </tbody>
        </table>
        

      7. Save the changes
        1. Confirm that the changes persisted after the save
      8. Add some entries and view the list
        1. Confirm that the table renders correctly
      9. Enable the HTML editor in some of the template tabs and make a note of which you have done so for
      10. Back up the activity and restore it into a new course
        1. Confirm that the HTML editor setting persisted across the backup/restore
      Show
      Create a new database activity and add some fields to it: Name (text input) Recommend (checkbox with option Yes) Open the templates editor For each type of HTML template: Confirm that you can disable the HTML editor Confirm that you can re-enable the HTML editor Confirm that after setting each state you can switch to another page and upon return, the editor state is remembered Confirm that the editor state persists between session Confirm that the editor state persists when a different user views the template Confirm that the editor state is specific to the type of template being edited Confirm that a confirmation dialogue is shown when re-enabling the HTML editor Navigate to the "List view" template editor Disable the HTML editor Enter an open tag in the Header section and a corresponding close tag in the Footer section, e.g. Header: <table class="table table-bordered table-hover table-condensed"> <thead> <tr> <th>Name</th> <th>Recommend</th> <th>Author</th> <th>Controls</th> </tr> </thead> <tbody> Body: <tr class="##approvalstatus##"> <td>[[Name]]</td> <td>[[Recommended]]</td> <td>##user##</td> <td>##edit## ##more## ##delete## ##approve## ##disapprove## ##export##</td> </tr> Footer: </tbody> </table> Save the changes Confirm that the changes persisted after the save Add some entries and view the list Confirm that the table renders correctly Enable the HTML editor in some of the template tabs and make a note of which you have done so for Back up the activity and restore it into a new course Confirm that the HTML editor setting persisted across the backup/restore
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-55866-master

      Description

      When creating the List template you are able to provide HTML for three template areas:

      • header
      • repeated items
      • footer

      At the moment these default to being HTML editors, however there are often times where you wish to open an HTML tag in the header, and close it in the footer - for example, a table.

      Although you already can disable the editor, when you view the page later after saving changes, it appears as an HTML editor.

      Since the Atto editor uses Content editable, browsers will automatically tidy up any invalid HTML. This means that any unclosed HTML tags are closed automatically, thus destroying the intent of the template.

      We need to remember the current state of the editor, particularly for the List template and perhaps warn when re-enabling the editor .

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16