Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55874

Course participation report broken HTML when messaging is disabled.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to a course with some enrolled students and login as a teacher.
      2. Select Reports > Course Participation and show a report for an activity
      3. VERIFY: inspect the generated html, ensure a form tag with id studentsform is present
      4. VERIFY: that you can see options to message students
      5. Disable messaging in site settings
      6. VERIFY: that you can no longer message students when going to the same place
      7. VERIFY: inspect the generated html, ensure a form tag with id studentsform is NOT present

      Validate html:

      1. Disable all blocks from the page (to eliminate them from test)
      2. Run w3c validator on the html. It should pass. (If it doesn't confirm they are related to this page before failing)

      Verify the table looks the same visually before and after the patch.

      Show
      Go to a course with some enrolled students and login as a teacher. Select Reports > Course Participation and show a report for an activity VERIFY: inspect the generated html, ensure a form tag with id studentsform is present VERIFY: that you can see options to message students Disable messaging in site settings VERIFY: that you can no longer message students when going to the same place VERIFY: inspect the generated html, ensure a form tag with id studentsform is NOT present Validate html: Disable all blocks from the page (to eliminate them from test) Run w3c validator on the html. It should pass. (If it doesn't confirm they are related to this page before failing) Verify the table looks the same visually before and after the patch.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-55874-master

      Description

      When messaging is disabled, the output from the course participation report does not close the <form> tag.
      This causes incorrect HTML output, which then breaks some themes depending on their layout structure.

      This bug was introduced by MDL-51988

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              iamandrew Andrew Davidson
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16