Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55876

core_course_update_courses allows category update of site which breaks site

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide
      1. Run vendor/bin/phpunit course/tests/courselib_test.php
      2. Make sure it pass.
      1. Try to update information on course id 1 (SITEID) using core_course_update_courses and make sure you get an exception.
      Show
      Run vendor/bin/phpunit course/tests/courselib_test.php Make sure it pass. Try to update information on course id 1 (SITEID) using core_course_update_courses and make sure you get an exception.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55876-master
    • Sprint:
      3.2 Sprint 5

      Description

      We had a MoodleCloud customer site break and upon investigation learnt that there were no longer any courses in category 0. this triggers a "nosite" exception from https://github.com/moodle/moodle/blob/master/lib/datalib.php#L564

      Going through the apache logs, the user sent a webservice request to core_course_update_courses which resulted in a 200 OK followed by a request to core_course_get_courses which returned a 503 at which point the site was throwing the "nosite" exception.

      If any HQ devs want to see the full log, please come see me

        Attachments

          Activity

            People

            Assignee:
            lameze Simey Lameze
            Reporter:
            jtomkinson Jordan Tomkinson
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Andrew Nicols
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Nov/16