Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.2
Affects Version/s: 2.9.7, 3.0.5, 3.1, 3.2
Component/s: Administration
Labels:
- CatalystIT
- api_change
- ci
- partner
- release_notes
- upgrade_notes

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull Main Branch:
~~MDL-55916~~-maintmode-503
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...brendanheywood:MDL-55916-maintmode-503
Testing Instructions:
Hide

Note - To check for response code:

Open your browser's developer tools, click on the Network tab.

Reload the page.

Select the resource that is being loaded (e.g. if you loaded http://[YOUR_MOODLE]/my/, select the entry for my/.

Click on the Headers tab and inspect the Status Code, Status and Retry-After response headers.

Testing procedure

run php admin/cli/maintenance.php --enable, load any page and confirm it serves a 503

php admin/cli/maintenance.php --disable, confirm 200 again

php admin/cli/maintenance.php --enableold, load a deep link and confirm it serves a 503

php admin/cli/maintenance.php --disable, confirm 200 again

Put a site into maint mode from the gui, load a deep link in incognito mode and confirm it serves a 503
Show
Note - To check for response code: Open your browser's developer tools, click on the Network tab. Reload the page. Select the resource that is being loaded (e.g. if you loaded http://[YOUR_MOODLE]/my/ , select the entry for my/ . Click on the Headers tab and inspect the Status Code , Status and Retry-After response headers. Testing procedure run php admin/cli/maintenance.php --enable, load any page and confirm it serves a 503 php admin/cli/maintenance.php --disable, confirm 200 again php admin/cli/maintenance.php --enableold, load a deep link and confirm it serves a 503 php admin/cli/maintenance.php --disable, confirm 200 again Put a site into maint mode from the gui, load a deep link in incognito mode and confirm it serves a 503

Plenty of good articles for why this is better eg:

http://stackoverflow.com/questions/2786595/what-is-the-correct-http-status-code-to-send-when-a-site-is-down-for-maintenance

This is especially important for big sites with lots of publicly available and indexed pages so that google never crawls these and gets the outage page and indexes it.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

screenshot-1.png
110 kB
14/Sep/16 10:58 PM

has a non-specific relationship to

MDL-47271 Add system status report including tasks with cli status script

Closed

MDL-56041 Cleanup custom 404 page and more easily support custom 50x error pages

Closed

has been marked as being related by

MDL-64473 Allow an administrator to set an arbitrary http return code for maintenance mode

Closed

MDL-71012 HTTP 503 Service Not Available is returned by exceptions and should be 500 instead

Closed

Testing discovered

MDL-56050 Course context not set on report_log produces error

Closed

MDL-56036 Webservices errors should throw proper http code

Closed

(1 Testing discovered)

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Jun Pataleta

Integrator:: Dan Poltawski

Tester:: Simey Lameze

Participants:: Brendan Heywood, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Jun Pataleta, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 11/Sep/16 3:37 AM

Updated:: 01/Mar/21 8:46 PM

Resolved:: 24/Sep/16 2:25 AM

Details

Note - To check for response code:

Testing procedure

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify