Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55921

PHPUnit profiling can produce warnings

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      rm -fr /tmp/phpu_moodledata   # Your moodle data folder
      # In config.php, set $CFG->phpunit_profilingenabled = 1;
      # edit version.php and change $version.
      vendor/bin/phpunit
      # No errors should be produced
      # Run init as suggested
      vendor/bin/phpunit
      

      Tests will pass with no errors output.

      Show
      rm -fr /tmp/phpu_moodledata # Your moodle data folder # In config.php, set $CFG->phpunit_profilingenabled = 1; # edit version.php and change $version. vendor/bin/phpunit # No errors should be produced # Run init as suggested vendor/bin/phpunit Tests will pass with no errors output.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:

      Description

      During followup testing of MDL-55504, I discovered the protections put in place during the final delivery of MDL-55504 were not sufficient to remove the errors around version and release.

      rm -fr /tmp/phpu_moodledata
      vendor/bin/phpunit
      

      Will produce warnings before printing the profiling information.

      PHPUNIT_UTIL was excluded in MDL-55504, however I believe it should be included as it's useful.

      Version and release data is neither verified or imported. It's only included in the output schema.

      Options
      1. Set default version and release if it's not available.
      2. or Add https://github.com/dmonllao/moodle/commit/30fbc3ecab3cd0bd9b15aed9dc5ae62436e7d475
      3. Decide if PHPUNIT_UTIL exclusion should be removed

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16