Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55942

General code cleanup after integration review

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: Messages
    • Labels:

      Description

      1. Check docs.
      2. Coding styles.
      3. Unused variables.
      4. Missing global declarations.
      5. Moving logic we added from message/lib.php to message/classes/api.php.
      6. Rename 'people' to 'user'.
      7. Remove behat tests that are failing.
      8. Cleanup message/index.php
      9. Do not store all selectors in one JS file (The selector list in message_area.js contains the list of all the selectors, which got quite large in the end).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Ryan Wyllie
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: