Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55945

Forgot password stopped working with loginhttps

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • MOODLE_27_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-55945-master
    • Hide
      1. Set up https on your local server. If using ubuntu/apache, you can follow the guide here. Confirm that you can access a test file on localhost over https (not your Moodle install, which will probably redirect) before proceeding.
      2. Enable httpslogin in Moodle (Site admin > Security > HTTP security)
      3. Run through the testing instructions in MDL-50803 and confirm that everything works as expected over https.
      Show
      Set up https on your local server. If using ubuntu/apache, you can follow the guide here . Confirm that you can access a test file on localhost over https (not your Moodle install, which will probably redirect) before proceeding. Enable httpslogin in Moodle (Site admin > Security > HTTP security) Run through the testing instructions in MDL-50803 and confirm that everything works as expected over https.

    Description

      Reported here. Looks like I missed https support in my patch for MDL-50803.

      Suggested patch:
      change:

      redirect($CFG->wwwroot . '/login/forgot_password.php');
      

      to:

      if ($CFG->loginhttps) {
          redirect($CFG->httpswwwroot . '/login/forgot_password.php');
      } else {
          redirect($CFG->wwwroot . '/login/forgot_password.php');
      }
      

      Attachments

        Issue Links

          Activity

            People

              jaked Jake Dallimore
              millmore Martin Millmore
              Mark Nelson Mark Nelson
              David Monllaó David Monllaó
              David Monllaó David Monllaó
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/16