Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55950

Feedback Activity email link only works for a single feedback submission from a single user

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. You need email enabled on your site to test it
      2. Create a non-anonymous feedback on the front page and map it to two courses, add some questions (one is enough). Make sure feedback has setting "Enable notification of submissions" = "Yes"
      3. In these courses add "Feedback" block
      4. Make sure you have at least one user with permission 'mod/feedback:receivemail' in the context of this feedback. For example, add this permission to Manager role and assign a system role manager to one user (alternative is to override permissions in the module context).
      5. As a student go to each of the courses and complete feedbacks (link will be in the "Feedback" block)
      6. Check emails, the links in the bottom of the email should go to different responses
      Show
      You need email enabled on your site to test it Create a non-anonymous feedback on the front page and map it to two courses, add some questions (one is enough). Make sure feedback has setting "Enable notification of submissions" = "Yes" In these courses add "Feedback" block Make sure you have at least one user with permission 'mod/feedback:receivemail' in the context of this feedback. For example, add this permission to Manager role and assign a system role manager to one user (alternative is to override permissions in the module context). As a student go to each of the courses and complete feedbacks (link will be in the "Feedback" block) Check emails, the links in the bottom of the email should go to different responses
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-55950-master

      Description

      When the Feedback activity sends out an email, it includes the text "It is available on the site", where the "available on the site" is a link to the feedback record. However, it only works if the user has only submitted a single feedback. If multiple feedbacks have been submitted by an individual user, then an error message is displayed saying "multiple records found, only one record expected", which takes me to error/moodle/multiplerecordsfound.

      The link includes the id number and the user id, but not the actual submission number. So, it includes "mod/feedback/show_entries.php?id=xxxxxx&userid=xxxxx", but I believe it should really have the following appended to it, to identify the submission "&showcompleted=xxx".

        Attachments

          Activity

            People

            Assignee:
            marina Marina Glancy
            Reporter:
            anntp Ann Tupman
            Peer reviewer:
            Juan Leyva
            Integrator:
            David Monllaó
            Tester:
            Andrew Nicols
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/May/17