Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55987

Gradebook calculation may need a lot of memory

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      To tester: the priority here is just to test for accidental regressions because the change is straight forward. If time does not allow, a small dataset will be sufficient.

      This has been tested intensively during the debugging on moodle.org staging copy. This can be tested e.g. by having a course with many users (like several thousands) and adding a graded activity into a course. That is one of the ways to trigger the gradebook update.

      Show
      To tester: the priority here is just to test for accidental regressions because the change is straight forward. If time does not allow, a small dataset will be sufficient. This has been tested intensively during the debugging on moodle.org staging copy. This can be tested e.g. by having a course with many users (like several thousands) and adding a graded activity into a course. That is one of the ways to trigger the gradebook update.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-55987-master-grademem

      Description

      In MDL-49332, Eric Merrill raised time limits for final grades calculations. As we learnt at moodle.org, in a course with 7500 students and 70 graded activities, the memory may easily become problem, too.

      This has significant impact as there is no way to add a graded activity to the course or access the gradebook, for example.

      The full story of how we experienced this on moodle.org and how we tracked it down can be seen in MDLSITE-4750. Shortly, we needed to add raise_memory_limit(MEMORY_EXTRA); to grade_regrade_final_grades() to make the site usable again. It seems like reasonable step to have this in the core.

        Attachments

        1. screenshot-1.png
          screenshot-1.png
          44 kB
        2. screenshot-2.png
          screenshot-2.png
          84 kB
        3. screenshot-3.png
          screenshot-3.png
          64 kB
        4. screenshot-4.png
          screenshot-4.png
          73 kB
        5. screenshot-5.png
          screenshot-5.png
          49 kB

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Eric Merrill
              Integrator:
              Dan Poltawski
              Tester:
              Jake Dallimore
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16